Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev clang format #37

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Dev clang format #37

wants to merge 2 commits into from

Conversation

MariusBgm
Copy link
Collaborator

@MariusBgm MariusBgm commented May 6, 2024 •
edited by VJanKraemer

Subject

Run clang-format on all C and C++ files

Description

Used the following script:

find SilKit/ Demos/ Utilities/ \
    -type f -iname *.cpp -o -iname *.hpp -o -iname *.c -o -iname *.ipp \
    -o -iname *.h   | while read fname;
do
    clang-format-16 -i --style=file  $fname;
done

[UPDATE]
Fixed clang-format version to 16, for compat reasons

Instructions for review / testing

Developer checklist (address before review)

  • Changelog.md updated
  • Prepared update for depending repositories
  • Documentation updated (public API changes only)
  • API docstrings updated (public API changes only)
  • Rebase → commit history clean
  • Squash and merge → proper PR title

@MariusBgm MariusBgm temporarily deployed to public-github-runners May 6, 2024 14:59 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 6, 2024 14:59 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 6, 2024 14:59 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 6, 2024 14:59 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 6, 2024 14:59 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 6, 2024 14:59 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 6, 2024 14:59 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 7, 2024 13:34 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 7, 2024 13:34 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 7, 2024 13:34 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 7, 2024 13:34 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 7, 2024 13:34 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 7, 2024 13:34 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 7, 2024 13:34 — with GitHub Actions Inactive
@MariusBgm MariusBgm marked this pull request as ready for review May 7, 2024 13:58
@MariusBgm MariusBgm marked this pull request as draft May 7, 2024 14:01
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 7, 2024 14:04 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 7, 2024 14:04 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 7, 2024 14:04 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 7, 2024 14:04 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 7, 2024 14:04 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 7, 2024 14:04 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 7, 2024 14:04 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer mentioned this pull request May 8, 2024
Open
6 tasks
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 21, 2024 08:28 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 21, 2024 08:28 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 21, 2024 08:28 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 21, 2024 08:28 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 21, 2024 08:28 — with GitHub Actions Inactive
@MariusBgm MariusBgm had a problem deploying to public-github-runners May 21, 2024 08:28 — with GitHub Actions Failure
@MariusBgm MariusBgm had a problem deploying to public-github-runners May 21, 2024 08:28 — with GitHub Actions Failure
@MariusBgm MariusBgm marked this pull request as ready for review May 21, 2024 08:28
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 21, 2024 09:19 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 21, 2024 09:19 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 21, 2024 09:19 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 21, 2024 09:19 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 21, 2024 09:19 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 21, 2024 09:19 — with GitHub Actions Inactive
@MariusBgm MariusBgm temporarily deployed to public-github-runners May 21, 2024 09:19 — with GitHub Actions Inactive
VJanKraemer
VJanKraemer reviewed May 21, 2024
View reviewed changes
.clang-format
AlignTrailingComments: false
# > clang-format-13
# Kind: Leave
# OverEmptyLines: 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we uncomment this? Below we also have the lambda configs which assume clang-format-13+

VJanKraemer
VJanKraemer reviewed May 21, 2024
View reviewed changes
Demos/Ethernet/EthernetDemo.cpp
@@ -29,10 +29,10 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
#include <vector>

#ifdef SILKIT_HOURGLASS
#include "silkit/hourglass/SilKit.hpp"
#include "silkit/hourglass/config/IParticipantConfiguration.hpp"
# include "silkit/hourglass/SilKit.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks funky 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe BeforeHash for
https://clang.llvm.org/docs/ClangFormatStyleOptions.html#indentppdirectives
Would be a better Option?

SilKit/IntegrationTests/ITest_AsyncSimTask.cpp Outdated
std::cout << "Sync SimTask now=" << now.count() << std::endl;
syncTimeNs = now;
}, 1ms);
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the feeling, that the brace indent might be switched here.

@VJanKraemer VJanKraemer temporarily deployed to public-github-runners May 21, 2024 15:16 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners May 21, 2024 15:16 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners May 21, 2024 15:16 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners May 21, 2024 15:16 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners May 21, 2024 15:16 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners May 21, 2024 15:16 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners May 21, 2024 15:16 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VJanKraemer VJanKraemer VJanKraemer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MariusBgm @VJanKraemer