Skip to content

feat: re-add unicode string escapes#1640

Draft
thomasqueirozb wants to merge 1 commit intomainfrom
dd/unicode-escape-support
Draft

feat: re-add unicode string escapes#1640
thomasqueirozb wants to merge 1 commit intomainfrom
dd/unicode-escape-support

Conversation

@thomasqueirozb
Copy link
Copy Markdown
Contributor

PR by Bits
View session in Datadog


Summary

Add support for \u{...} Unicode escapes in VRL string literals, validate the escape sequences in the lexer, harden unescape handling to avoid panics, and add tests plus a changelog fragment.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

  • Run tests

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on
    our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Our CONTRIBUTING.md is a good starting place.
  • If this PR introduces changes to LICENSE-3rdparty.csv, please
    run dd-rust-license-tool write and commit the changes. More details here.
  • For new VRL functions, please also create a sibling PR in Vector to document the new function.

References

Co-authored-by: thomasqueirozb <38295417+thomasqueirozb@users.noreply.github.com>
@datadog-vectordotdev
Copy link
Copy Markdown
Contributor

[View session in Datadog]

Bits Dev status: ✅ Done

@thomasqueirozb

This comment was marked as off-topic.

@chatgpt-codex-connector

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant