Skip to content

fix(stdlib): use vector tokio runtime instead of using a worker thread #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

esensar
Copy link
Contributor

@esensar esensar commented May 29, 2025

Summary

This removes the needless worker thread from dns_lookup and just blocks on the current tokio runtime (if available). Worker thread code was blocking anyways, this just removes all of that coordination code.

I am not sure if this will actually make much of an impact, but I wanted to simplify this, because we have seen some issue with dns_lookup and this whole worker thread thing made things more complicated unnecessarily, because it was still blocking anyways.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Ran existing tests as well as running it inside vector. It seems to work as before.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on
    our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Our CONTRIBUTING.md is a good starting place.
  • If this PR introduces changes to LICENSE-3rdparty.csv, please
    run dd-rust-license-tool write and commit the changes. More details here.
  • For new VRL functions, please also create a sibling PR in Vector to document the new function.

References


Sponsored by Quad9

This removes the needless worker thread from `dns_lookup` and just blocks on the current tokio
runtime (if available). Worker thread code was blocking anyways, this just removes all of that
coordination code.

Related: vectordotdev#882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant