fix(stdlib): use vector tokio runtime instead of using a worker thread #1407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes the needless worker thread from
dns_lookup
and just blocks on the current tokio runtime (if available). Worker thread code was blocking anyways, this just removes all of that coordination code.I am not sure if this will actually make much of an impact, but I wanted to simplify this, because we have seen some issue with
dns_lookup
and this whole worker thread thing made things more complicated unnecessarily, because it was still blocking anyways.Change Type
Is this a breaking change?
How did you test this PR?
Ran existing tests as well as running it inside vector. It seems to work as before.
Does this PR include user facing changes?
our guidelines.
Checklist
run
dd-rust-license-tool write
and commit the changes. More details here.References
dns_lookup
#882