Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): revert to a previous async-nats version #22359

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pront
Copy link
Member

@pront pront commented Feb 3, 2025

Summary

Reverted async-nats bump and tests are now passing.

Follow up: Need to ensure that the IT suite runs when dependencies change.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
    • make check-all is a good command to run locally. This check is
      defined here. Some of these
      checks might not be relevant to your PR. For Rust changes, at the very least you should run:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

Ref: #22242 (comment)

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Feb 3, 2025
Copy link
Member Author

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-integration-all

@pront pront added do not merge no-changelog Changes in this PR do not need user-facing explanations in the release changelog labels Feb 4, 2025
Copy link
Member Author

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-integration-nats

Copy link
Member Author

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-integration-nats

@pront pront added domain: tests Anything related to Vector's internal tests domain: sources Anything related to the Vector's sources and removed do not merge labels Feb 4, 2025
@pront pront changed the title DO NOT MERGE - TEST RUN fix(ci): revert to a previous async-nats version Feb 4, 2025
@pront
Copy link
Member Author

pront commented Feb 4, 2025

@pront pront marked this pull request as ready for review February 4, 2025 19:40
@pront pront requested a review from a team as a code owner February 4, 2025 19:40
@github-actions github-actions bot removed domain: sources Anything related to the Vector's sources domain: sinks Anything related to the Vector's sinks labels Feb 4, 2025
@pront pront requested a review from jszwedko February 4, 2025 19:41
@pront pront enabled auto-merge February 4, 2025 20:01
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Feb 4, 2025

Datadog Report

Branch report: pront/test-nats-int-tests
Commit report: a0a69b2
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.46s Total Time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: tests Anything related to Vector's internal tests no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants