Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SASSV1 #174

Merged
merged 8 commits into from
Aug 28, 2024
Merged

SASSV1 #174

merged 8 commits into from
Aug 28, 2024

Conversation

WildBillDev
Copy link
Contributor

Sass token commits with PW

@WildBillDev
SASSV1
599c45a 
Sass token commit
@WildBillDev
Copy link
Contributor Author

Thanks for making this easy :)

Much Love,
Wild Bill

@WildBillDev
Copy link
Contributor Author

WildBillDev commented Aug 20, 2024 •
edited
Loading

changed the SASS to sass as well let me know if im doing something wrong on my end much love...
So i found the details and did see that i had used caps when i should have used none so that is fixed now.

@libotony
Copy link
Member

Info from script, symbol does not match contract symbol (info=sass, contract=$sass). Could you kindly check?

@WildBillDev
Copy link
Contributor Author

do i need to add the $ to this

@WildBillDev
Copy link
Contributor Author

have looked and yes its got the $ in it am working on the push right now for some reason i thought it was not needed lol one sec

@WildBillDev
fix $
d38c031 
fixed the $sass
@WildBillDev
Copy link
Contributor Author

there that should work now boy im sorry for all this over one symbol feel stupid lol

@WildBillDev
Copy link
Contributor Author

I was going by examples in the repo

@WildBillDev @libotony
SASSV1
46b8bf7 
Sass token commit
@WildBillDev @libotony
fix
7ea156a
@WildBillDev @libotony
fix $
f9c1119 
fixed the $sass
libotony
libotony reviewed Aug 26, 2024
View reviewed changes
tokens/main/0x9b84cf29c8b5b906dd88e85fe6262f1ce1384f6b/additional.json Outdated
Comment on lines 5 to 6
"founder_twitter":"https://twitter.com/WildBillArt",
"Co_founder_twitter":"https://twitter.com/PaullyTV",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only twitter is allowed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k sounds good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol wasn't sure but figured i would try lol I am away from PC I will get this done by tonight

@WildBillDev
Merge branch 'master' of https://github.com/WildBillDev/token-registr…
cd6f41d 
…y-SASS
@WildBillDev
fix2
82f4fee 
sorry for all these mistakes am going to be expert on this by time done lol
@libotony libotony merged commit 2c506db into vechain:master Aug 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@libotony libotony libotony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WildBillDev @libotony