✨ Add rollout restart e2e/v2 test #2875

vankichi · 2025-02-27T05:20:17Z

Description

Related Issue

Versions

Vald Version: v1.7.16
Go Version: v1.24.0
Rust Version: v1.84.1
Docker Version: v27.4.0
Kubernetes Version: v1.32.0
Helm Version: v3.16.3
NGT Version: v2.3.5
Faiss Version: v1.9.0

Checklist

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer

coderabbitai · 2025-02-27T05:20:23Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)

main
master
release/*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vdaas-ci · 2025-02-27T05:23:45Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Signed-off-by: kpango <[email protected]>

cloudflare-workers-and-pages · 2025-02-27T06:46:47Z

Deploying vald with Cloudflare Pages

Latest commit:	`4eb2f20`
Status:	✅ Deploy successful!
Preview URL:	https://0abfd57a.vald.pages.dev
Branch Preview URL:	https://refactor-test-e2e-add-e2e-sc.vald.pages.dev

View logs

vankichi · 2025-03-05T04:45:37Z

tests/v2/e2e/crud/rollout_test.go

+
+		eg, egctx := errgroup.New(ctx)
+		eg.Go(safety.RecoverFunc(func() error {
+			statefulSetClient := kclient.GetClientSet().AppsV1().StatefulSets("default")


Suggested change

statefulSetClient := kclient.GetClientSet().AppsV1().StatefulSets("default")

statefulSetClient := kubernetes.Statefulset(kclient, ns)

Suggested change

statefulSetClient := kclient.GetClientSet().AppsV1().StatefulSets("default")

func rolloutRestartForTest(ctx context.Context, ns string, name string, t *testing.T) {

t.Helper()

...

}

codecov · 2025-03-05T08:44:00Z

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 24.02%. Comparing base (e7bbdb8) to head (4eb2f20).

Files with missing lines	Patch %	Lines
pkg/agent/core/ngt/service/ngt.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@                           Coverage Diff                            @@
##           refactor/test-e2e/add-v2-e2e-testing    #2875      +/-   ##
========================================================================
+ Coverage                                 16.91%   24.02%   +7.10%     
========================================================================
  Files                                       136      501     +365     
  Lines                                     15057    50423   +35366     
========================================================================
+ Hits                                       2547    12113    +9566     
- Misses                                    12213    37597   +25384     
- Partials                                    297      713     +416

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: vankichi <[email protected]>

vdaas-ci · 2025-03-06T07:07:56Z

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

This commit fixes the style issues introduced in ea6634e according to the output from Gofumpt and Prettier. Details: #2875

github-actions bot added area/makefile size/XXL type/refactoring labels Feb 27, 2025

github-actions bot added the priority/low label Feb 27, 2025

kpango force-pushed the refactor/test-e2e/add-v2-e2e-testing branch from e9d5aef to 3710cbb Compare February 27, 2025 05:54

Refactor add V2 E2E testing for more maintainability

e7bbdb8

Signed-off-by: kpango <[email protected]>

kpango force-pushed the refactor/test-e2e/add-v2-e2e-testing branch from 3710cbb to e7bbdb8 Compare February 27, 2025 06:15

vankichi force-pushed the refactor/test-e2e/add-e2e-sc-rollout-index-job branch from e53207c to adda852 Compare February 27, 2025 06:46

vankichi force-pushed the refactor/test-e2e/add-e2e-sc-rollout-index-job branch from adda852 to a4b1bf4 Compare February 27, 2025 06:49

github-actions bot mentioned this pull request Mar 1, 2025

Monthly review time metrics report: 2025-02-01..2025-02-28 #2877

Closed

vankichi force-pushed the refactor/test-e2e/add-e2e-sc-rollout-index-job branch 2 times, most recently from 58905db to bdb3715 Compare March 4, 2025 09:08

github-actions bot added the type/ci label Mar 4, 2025

vankichi commented Mar 5, 2025

View reviewed changes

vankichi force-pushed the refactor/test-e2e/add-e2e-sc-rollout-index-job branch from bdb3715 to 0c748fb Compare March 5, 2025 08:31

github-actions bot added the area/agent/core/ngt label Mar 5, 2025

vankichi force-pushed the refactor/test-e2e/add-e2e-sc-rollout-index-job branch from 0c748fb to bfd5376 Compare March 6, 2025 04:48

✨ Add rollout restart e2e/v2 test

ea6634e

Signed-off-by: vankichi <[email protected]>

vankichi force-pushed the refactor/test-e2e/add-e2e-sc-rollout-index-job branch from bfd5376 to ea6634e Compare March 6, 2025 07:07

github-actions bot added the area/internal label Mar 6, 2025

style: format code with Gofumpt and Prettier

4eb2f20

This commit fixes the style issues introduced in ea6634e according to the output from Gofumpt and Prettier. Details: #2875

kpango force-pushed the refactor/test-e2e/add-v2-e2e-testing branch 2 times, most recently from fd8961e to d4f681c Compare March 6, 2025 21:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Add rollout restart e2e/v2 test #2875

✨ Add rollout restart e2e/v2 test #2875

vankichi commented Feb 27, 2025

coderabbitai bot commented Feb 27, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

vdaas-ci commented Feb 27, 2025

cloudflare-workers-and-pages bot commented Feb 27, 2025 •

edited

Loading

vankichi Mar 5, 2025

codecov bot commented Mar 5, 2025 •

edited

Loading

vdaas-ci commented Mar 6, 2025

	statefulSetClient := kclient.GetClientSet().AppsV1().StatefulSets("default")
	statefulSetClient := kubernetes.Statefulset(kclient, ns)

-			statefulSetClient := kclient.GetClientSet().AppsV1().StatefulSets("default")
+func rolloutRestartForTest(ctx context.Context, ns string, name string, t *testing.T) {
+    t.Helper()
+    ...
+}

✨ Add rollout restart e2e/v2 test #2875

Are you sure you want to change the base?

✨ Add rollout restart e2e/v2 test #2875

Conversation

vankichi commented Feb 27, 2025

Description

Related Issue

Versions

Checklist

Special notes for your reviewer

coderabbitai bot commented Feb 27, 2025 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

vdaas-ci commented Feb 27, 2025

cloudflare-workers-and-pages bot commented Feb 27, 2025 • edited Loading

Deploying vald with Cloudflare Pages

vankichi Mar 5, 2025

Choose a reason for hiding this comment

codecov bot commented Mar 5, 2025 • edited Loading

Codecov Report

vdaas-ci commented Mar 6, 2025

coderabbitai bot commented Feb 27, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

cloudflare-workers-and-pages bot commented Feb 27, 2025 •

edited

Loading

codecov bot commented Mar 5, 2025 •

edited

Loading