Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit potential function #810

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Use explicit potential function #810

merged 4 commits into from
Dec 2, 2024

Conversation

elazarg
Copy link
Collaborator

@elazarg elazarg commented Dec 2, 2024

Avoid using template for array-like access

Summary by CodeRabbit

  • New Features

    • Introduced a more flexible approach for handling potential functions in graph operations, allowing any callable type to be used.
    • Enhanced methods for managing graph operations, improving their functionality and maintainability.
  • Bug Fixes

    • Improved error handling for potential overflows during data type conversions, ensuring robustness.
  • Documentation

    • Updated comments and formatting for better readability and clarity.
  • Refactor

    • Updated type alias for Weight in the SplitDBM class to enhance clarity and consistency.

Signed-off-by: Elazar Gershuni <[email protected]>

This comment was marked as off-topic.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between bc91973 and a1331aa.

📒 Files selected for processing (2)
  • src/crab/split_dbm.cpp (6 hunks)
  • src/crab_utils/graph_ops.hpp (15 hunks)

src/crab_utils/graph_ops.hpp Show resolved Hide resolved
src/crab_utils/graph_ops.hpp Show resolved Hide resolved
src/crab/split_dbm.cpp Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Dec 2, 2024

Coverage Status

coverage: 89.556% (-0.02%) from 89.578%
when pulling 7a3bce0 on potential-function
into bc91973 on main.

shortcut populating delta in dijkstra_recover

Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
@elazarg elazarg merged commit 2acaa27 into main Dec 2, 2024
19 checks passed
@elazarg elazarg deleted the potential-function branch December 2, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants