Use T_UNINIT as lower bound for types

[elazarg]

Fix a crash when running on build/loop.o.

Summary by CodeRabbit

• New Features

  • Updated the minimum type encoding value to enhance type encoding operations.

• Bug Fixes

  • Reviewed logic surrounding type encoding usage for compatibility with the new minimum value.

[coderabbitai]

Walkthrough

The changes in this pull request involve an update to the constant T_MIN within the type_encoding_t enumeration in the src/crab/type_encoding.hpp file. The value of T_MIN has been changed from T_MAP_PROGRAMS to T_UNINIT, while the maximum value T_MAX remains as T_SHARED. This modification affects the minimum type encoding value used in type encoding operations, but does not alter any function signatures or the overall structure of the enums or classes.

Changes

File	Change Summary
src/crab/type_encoding.hpp	Updated constexpr type_encoding_t T_MIN from T_MAP_PROGRAMS to T_UNINIT.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between e09c6a7 and 26f7032.

📒 Files selected for processing (1)

• src/crab/type_encoding.hpp (1 hunks)

🔇 Additional comments (1)

src/crab/type_encoding.hpp (1)

43-43: Verify TypeGroup behavior with T_UNINIT

The change to include T_UNINIT in the valid range is logical for handling uninitialized values. However, verify that TypeGroup comparisons handle T_UNINIT correctly.

✅ Verification successful

T_UNINIT is handled correctly in TypeGroup comparisons

The codebase shows that TypeGroup comparisons are implemented safely with respect to T_UNINIT:

• mem: checks reg >= T_PACKET - unaffected by T_UNINIT
• mem_or_num: checks reg >= T_NUM && reg != T_CTX - unaffected by T_UNINIT
• pointer: checks reg >= T_CTX - unaffected by T_UNINIT
• ptr_or_num: checks reg >= T_NUM - unaffected by T_UNINIT
• stack_or_packet: checks reg >= T_PACKET && reg <= T_STACK - unaffected by T_UNINIT
• singleton_ptr: checks reg >= T_CTX && reg <= T_STACK - unaffected by T_UNINIT

All TypeGroup comparisons use either equality checks or lower bounds that are higher than T_UNINIT (-7), making the change safe.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if TypeGroup implementations handle T_UNINIT correctly
# Look for comparisons against type_encoding_t values that might need adjustment

# Search for type comparisons in implementation files
rg "T_(UNINIT|MAP_PROGRAMS|NUM|CTX|PACKET|STACK|SHARED)" --type cpp -A 2 -B 2

# Look for TypeGroup-related code
ast-grep --pattern 'TypeGroup'

Length of output: 36886

[coveralls]

coverage: 89.643% (-0.02%) from 89.665%
when pulling 26f7032 on min-T_UNINIT
into e09c6a7 on main.