-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update notest for Windows to install VS Clang #782
Conversation
WalkthroughThe changes in this pull request focus on updating the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)README.md (2)
The added requirements for "C++ Clang Compiler" and "MSBuild support for LLVM" are essential components for building the project on Windows.
While the current format is functional, the readability could be enhanced by adjusting the indentation and bullet point hierarchy. The formatting suggestion from the previous review is still valid: -* Install [Visual Studio Build Tools 2022](https://aka.ms/vs/17/release/vs_buildtools.exe) and:
- * Choose the "C++ build tools" workload (Visual Studio Build Tools 2022 has support for CMake Version 3.25)
- * Under Individual Components, select:
- * "C++ Clang Compiler"
- * "MSBuild support for LLVM"
+* Install [Visual Studio Build Tools 2022](https://aka.ms/vs/17/release/vs_buildtools.exe) and:
+ * Choose the "C++ build tools" workload (Visual Studio Build Tools 2022 has support for CMake Version 3.25)
+ * Under Individual Components, select:
+ * "C++ Clang Compiler"
+ * "MSBuild support for LLVM" Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Alan Jowett <[email protected]>
475828e
to
bc2d94c
Compare
This pull request includes an update to the
README.md
file to clarify the installation instructions for dependencies.README.md
)Summary by CodeRabbit