Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MOVSX immediate support #571

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Remove MOVSX immediate support #571

merged 1 commit into from
Feb 5, 2024

Conversation

dthaler
Copy link
Contributor

@dthaler dthaler commented Jan 21, 2024

Per recent discussion on the LKML, MOVSX is only defined for register, not immediate, source operands.
The documentation was incorrect and is being fixed.
Hence we can remove support for MOVSX immediate.

Fixes #568

@coveralls
Copy link

coveralls commented Jan 21, 2024

Coverage Status

coverage: 89.835% (-0.03%) from 89.866%
when pulling 125512d on dthaler:no-movsx-imm
into 96f4333 on vbpf:main.

@dthaler dthaler force-pushed the no-movsx-imm branch 2 times, most recently from ff27162 to 4d5e4d7 Compare February 2, 2024 19:38
@elazarg elazarg merged commit 342996d into vbpf:main Feb 5, 2024
13 checks passed
@dthaler dthaler deleted the no-movsx-imm branch February 5, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MOVSX shouldn't operate on immediate
3 participants