MIME handler cleanup #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tidy up some of the MIME code to be more concise
vaxerski
reviewed
Apr 22, 2025
Contributor
Author
|
Bump @vaxerski |
vaxerski
reviewed
May 17, 2025
| } | ||
| if (magic) | ||
| magic_close(magic); | ||
| if(magic) magic_close(magic); |
Owner
There was a problem hiding this comment.
this will not build? magic is a local within the if above. Just make the magic before the if, then if load succeeds do the stuff, then close if the ptr is not null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidy up some of the MIME code to be more concise