-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved deprecated Value.get* methods to single-valued types. #2557
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2557 +/- ##
============================================
+ Coverage 92.8% 93.02% +0.21%
- Complexity 5300 5551 +251
============================================
Files 89 89
Lines 12706 13101 +395
Branches 1609 1660 +51
============================================
+ Hits 11792 12187 +395
Misses 727 727
Partials 187 187
Continue to review full report at Codecov.
|
d773a9a
to
9611a7f
Compare
d8f2b8b
to
a752345
Compare
Codecov Report
@@ Coverage Diff @@
## master #2557 +/- ##
============================================
+ Coverage 92.84% 93.02% +0.18%
- Complexity 5347 5551 +204
============================================
Files 89 89
Lines 12740 13101 +361
Branches 1608 1660 +52
============================================
+ Hits 11828 12187 +359
- Misses 723 727 +4
+ Partials 189 187 -2
Continue to review full report at Codecov.
|
f5fb289
to
5c64f2a
Compare
d775e22
to
10085a7
Compare
Fixes #2450
This is a DRAFT pull request for deprecating the Value methods and moving them to the right locations. The main ideas are described in the blog post Purifying the API surface area.
Renaming things isn't a good idea regarding backward compatibility, however, moving some APIs to the right place is essential for the health of the Vavr library. Here are the main changes I did in this PR:
Removed from Value and sub-classes (without replacement):
Moved from Value to Traversable:
Moved from Value to Option, Try, Either, Validation, Future:
Moved Foldable.* to Traversable and removed Foldable interface:
Removed from collections:
Removed from Either (without replacement):
Removed from Future (without replacement):
Removed from Promise (without replacement):
Removed HashCodes interface (without replacement)
Removed from PartialFunction (without replacement):