Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include attribute equality properties in planner costs #6388

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

flyingsilverfin
Copy link
Member

What is the goal of this PR?

We identify and correct a mismatch between the execution of a procedure and the planner cost functions - notably the presence of an attribute's value equality predicate, which significantly constraints the search space but was not included in the cost function of traversing has edges in either direction.

What are the changes implemented in this PR?

  • generify the numerator or divisor of the has cost functions to include the potential presence of attribute equality constraints

@flyingsilverfin flyingsilverfin marked this pull request as draft June 29, 2021 14:24
@flyingsilverfin
Copy link
Member Author

flyingsilverfin commented Jun 29, 2021

NOTE

We decided to park this and revisit it as part of a general update/cleanup of the Query Planning coefficient computation.

As part of that, we should incorporate better costs to do with estimating the number of times we have to touch the DB (eg. open iterator, length of an iterator, or do a exact get lookup). We should also clean up assumptions in the Thing edges to do with not having resolved types available - we now operate under the assumption of always having them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants