Repo type #58
Open
Repo type #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@audunmg and @gquintard |
Collaborator
|
This needs a bit of cleaning up, some commits from another PR has snuck in here. (external traffic policy) |
Collaborator
|
Now it's just missing tests. |
Contributor
Author
|
Okay the tests have been added in repotype.bats as I did them using the new test method from @audunmg |
Collaborator
|
I think you have to rebase to main again, and delete the commits which are not related to this PR (externalTrafficPolicy, etc.) |
Collaborator
|
The public repo image is using a different entrypoint with different env variabels, so I think this could be a part of a series of PRs to unify the behavior. |
Contributor
Author
|
Hey @audunmg, I rebased again and believe I cleaned things up right. Can you take a look? |
briiians
force-pushed
the
repo-type
branch
2 times, most recently
from
75279d7 to
018c9b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a feature for defining a repo type that uses the global variable repoType to allow someone to choose "public-enterprise" for "varnish/enterprise" or "private-enterprise" for "quay.io/varnish-software/varnish-plus". I still need to add tests and docs, but I wanted to push this before I go on PTO until Monday.