Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support event tracing #607

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: support event tracing #607

wants to merge 5 commits into from

Conversation

hwjiangkai
Copy link
Contributor

@hwjiangkai hwjiangkai commented Jul 12, 2023

What problem does this PR solve?

support event tracing

enable related configurations in the gateway and trigger:

    observability:
      tracing:
        enable: false
        # OpenTelemetry Collector endpoint, https://opentelemetry.io/docs/collector/getting-started/
        otel_collector: http://127.0.0.1:4318
        event_tracing_enable: true
        # Vanus Controller endpoints
        event_collector: 
          - vanus-controller-0.vanus-controller.trace.svc.cluster.local:8080
          - vanus-controller-1.vanus-controller.trace.svc.cluster.local:8080
        eventbus: event-tracing

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #607 (daa31f6) into main (ee76217) will decrease coverage by 3.00%.
The diff coverage is 45.93%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
- Coverage   57.07%   54.07%   -3.00%     
==========================================
  Files         190      224      +34     
  Lines       15191    18125    +2934     
==========================================
+ Hits         8670     9801    +1131     
- Misses       5884     7534    +1650     
- Partials      637      790     +153     
Impacted Files Coverage Δ
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
...al/controller/trigger/subscription/subscription.go 58.29% <ø> (-0.28%) ⬇️
...rnal/controller/trigger/validation/subscription.go 62.64% <ø> (ø)
internal/controller/trigger/worker/manager.go 85.76% <ø> (+0.83%) ⬆️
internal/controller/trigger/worker/policy.go 100.00% <ø> (ø)
internal/controller/trigger/worker/scheduler.go 71.01% <ø> (+1.01%) ⬆️
internal/controller/trigger/worker/worker.go 78.45% <ø> (-1.55%) ⬇️
internal/gateway/config.go 60.60% <ø> (-0.51%) ⬇️
internal/gateway/gateway.go 55.26% <ø> (-12.41%) ⬇️
internal/gateway/proxy/auth.go 0.00% <ø> (ø)
... and 67 more

... and 67 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 895dd83...daa31f6. Read the comment docs.

@hwjiangkai hwjiangkai force-pushed the tracing branch 2 times, most recently from 920eaf7 to 2e0ef9d Compare July 13, 2023 02:54
Signed-off-by: jyjiangkai <[email protected]>
@hwjiangkai hwjiangkai force-pushed the tracing branch 5 times, most recently from 58b04d8 to af954f9 Compare July 17, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant