ConfigurableModel::hasConfiguration() returns false on empty arrays

vanilophp · Jul 24, 2024 · 2d869c7 · 2d869c7
1 parent 86b42ac
commit 2d869c7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/Changelog.md b/Changelog.md
@@ -2,6 +2,11 @@
 
 ## 4.x Series
 
+## Unreleased
+##### 2024-XX-YY
+
+- Changed the `ConfigurableModel::hasConfiguration()` trait to return false on empty arrays as well (until now, only `null` was considered as no config)
+
 ## 4.1.0
 ##### 2024-07-11
 

diff --git a/Traits/ConfigurableModel.php b/Traits/ConfigurableModel.php
@@ -42,7 +42,7 @@ public function configuration(): ?array
 
     public function hasConfiguration(): bool
     {
-        return null !== $this->{static::$configurationFieldName};
+        return !empty($this->{static::$configurationFieldName});
     }
 
     public function doesntHaveConfiguration(): bool