Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration: Split out compiler into @vanilla-extract/compiler package #1536

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Jan 28, 2025

There's a few things that motivated me to do this split:

  1. All bundler plugins depend on the integration package, which means they all and up pulling in vite and vite-node dependencies, yet most bundler integrations don't use the compiler yet. Splitting out the compiler into a separate package means these dependencies aren't installed in bundler integrations that don't use the compiler.
  2. A separate, 0-versioned compiler package allows less disruptive (less major versions) API iteration on the compiler. Although we don't care that much about major versions in the integration package, I still feel like the compiler's API and implementation is unstable enough that it should be treated as such. Isolating it in a separate package helps with this.

At a point in the future, it may make sense to merge the compiler back into the integration package.

Copy link

changeset-bot bot commented Jan 28, 2025

🦋 Changeset detected

Latest commit: 9cda792

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@vanilla-extract/vite-plugin Patch
@vanilla-extract/compiler Minor
@vanilla-extract/integration Major
@vanilla-extract/esbuild-plugin Patch
@vanilla-extract/jest-transform Patch
@vanilla-extract/parcel-transformer Patch
@vanilla-extract/rollup-plugin Patch
@vanilla-extract/webpack-plugin Patch
@vanilla-extract/next-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@askoufis askoufis merged commit a8248be into master Jan 29, 2025
12 checks passed
@askoufis askoufis deleted the split-out-compiler branch January 29, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants