Remove unused valDup #443
Remove unused valDup #443
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #443 +/- ##
============================================
- Coverage 70.22% 70.19% -0.04%
============================================
Files 109 109
Lines 59956 59958 +2
============================================
- Hits 42104 42086 -18
- Misses 17852 17872 +20
|
|
As mentioned on slack, can you run the performance test again with more keys and post the updated performance here. As long as there is a meaningful difference, I think it would be worth pulling it. |
|
For random key and small packets we will see some improvement. For larger packet the improvement is overshadowed by the overall load and is no longer measurable (though logic say it must be there however small). |
|
@eliblight Can you fix the DCO complaint? |
eliblight
force-pushed
the
try-to-remove-dup
branch
from
a956b50
to
b839456
Compare
|
Sorry for taking a bit to get back around to this, can you address the merge conflicts and update the PR? I'm happy with it otherwise. |
eliblight
force-pushed
the
try-to-remove-dup
branch
3 times, most recently
from
20c8e67
to
3153bc0
Compare
Signed-off-by: Eran Liberty <[email protected]>
PR by keeping the dict in dictSetVal and not using it. ... but mainly to make @madolson happy Signed-off-by: Eran Liberty <[email protected]>
eliblight
force-pushed
the
try-to-remove-dup
branch
from
09bf2c2
to
f30c6bc
Compare
|
@madolson your turn |
makes SERVER_CFLAGS='-DSERVER_TEST' compile as well Introduced in #443. Signed-off-by: Eran Liberty <[email protected]> Co-authored-by: Eran Liberty <[email protected]>
It turns out valDup is totally unused in the codebase