Add MS SQL Server as a DB Provider for RAG backend #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sauagarwa There's a lot of changes to clean up this pattern in addition to adding the subchart for deploying SQL Server for local deploy and Azure SQL server as a RAG DB provider.
I'll summarize the key changes:
values-global.yaml
) and you can use the valuesglobal.model.vllm
andglobal.model.tgis
to easily set the model used by the inference server and TGI server, respectivelyllm-serving-service
chart tovllm-inference-service
to further distinguish that we're using vLLM for that chart versus the HF TGI server in thetgis-server
chartWith these changes, we are able to install the chart on ROSA 4.18 as well as the ARO 4.14 provided by our demo platform and everything comes up healthy and synced regardless of your RAG DB provider. This ensures CI will begin passing again (as it checks for out-of-sync and unhealthy applications in ArgoCD).
Please let me know if there's anything you want me to change, move into a separate PR, etc. and I'm happy to do so.
One other important thing, right now this PR is using
quay.io/dminnear/gradio-tgi-multi-model-rag
because the latest changes to the UI haven't been built and pushed to https://quay.io/repository/ecosystem-appeng/rag-llm-ui?tab=info. If we can get that image updated with the latest https://github.com/RHEcosystemAppEng/llm-on-openshift/tree/main/examples/ui/gradio/gradio-tgi-multi-model-rag-redis I can revert that back to the proper image.