Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'create' project command #8

Merged
merged 14 commits into from
Mar 12, 2025
Merged

Add 'create' project command #8

merged 14 commits into from
Mar 12, 2025

Conversation

404Wolf
Copy link
Collaborator

@404Wolf 404Wolf commented Mar 5, 2025

02255c40-ca3c-44d1-941a-72ad820234dd

@404Wolf 404Wolf marked this pull request as ready for review March 6, 2025 00:26
Copy link
Member

@maxmcd maxmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

I do wonder if we should init a project with a readme (for humans and for LLMs) and maybe example http and script vals. But that is surely scope-creep for the time being.

Comment on lines +23 to +25
.option("--public", "Create as public project (default)")
.option("--private", "Create as private project")
.option("--unlisted", "Create as unlisted project")
Copy link
Member

@maxmcd maxmcd Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be better as an argument? vt create [privacy] or a single --privacy= flag?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to keep it similar to github's cli here. Github uses gh repo create --public foobar. What do you think with that in mind?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah cool, makes sense

@404Wolf
Copy link
Collaborator Author

404Wolf commented Mar 12, 2025

lgtm!

I do wonder if we should init a project with a readme (for humans and for LLMs) and maybe example http and script vals. But that is surely scope-creep for the time being.

I don't like this mostly because it adds discontinuity with the website, and is going to be better implemented once we get a fork endpoint and add a fork command. Configuration (files/global config) is not far down the road, and I think we should allow a user to provide a default project to fork when creating projects as one option. I also think we should let users specify a folder to use as their "template" (different from remote forks). We probably want to spend more time brainstorming this but I think this should be merged as-is for now if that's OK.

@maxmcd
Copy link
Member

maxmcd commented Mar 12, 2025

oh yeah just a thought, all good w/ me to merge

@404Wolf 404Wolf merged commit bd9065a into main Mar 12, 2025
2 checks passed
@404Wolf 404Wolf deleted the create-cmd branch March 12, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants