Allow video resolution hinting #1787
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 29, 2023 12:02
Libvirt supports setting custom video resolution by setting the resolution subelement in the model tag. This changes the preferred EDID mode exposed to the vm. Changing this is usefull when running GUI systems that does not provide UI elements for changing the resolution. Examples would be cage or other wayland compositors where initialization uses the preferred EDID mode.
make sure all tests pass
|
A docker image containing the code from this plugin to allow testing locally without installing If you need the image with the full dev toolchain, you can instead pull: ghcr.io/vagrant-libvirt/vagrant-libvirt:pr-1787 |
| @@ -194,6 +194,10 @@ end | |||
| "cirrus", "vmvga", "xen", "vbox", or "qxl". | |||
| * `video_vram` - Used by some graphics card types to vary the amount of RAM | |||
| dedicated to video. Defaults to 16384. | |||
| * `video_resolution_x` - sets the default EDID/monnitor resolution hinting for the X | |||
There was a problem hiding this comment.
While spitting the resolution into two separate variables makes it easier in some ways, I'm not sure it's particularly consistent with how many would expect it to work with 1280x800 being a more common form. Should be possible to validate the value matches [[:digit:]]{3,}x[[:digit:]]{3,} (or similar regex) if not nil in the config class and subsequently split when specifying the individual XML elememts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for custom video resolution
Libvirt supports setting custom video resolution by setting the
resolution subelement in the model tag. This changes the preferred EDID
mode exposed to the vm.
Changing this is usefull when running GUI systems that does not provide
UI elements for changing the resolution. Examples would be cage or other
wayland compositors where initialization uses the preferred EDID mode.