Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoUpdate without prompt: immediate App restart #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

carlo318
Copy link

With this modification the app is able to AutoUpdate and Restart without the prompt "The App needs to be updated", that is without the need for the user to tap on button "Update".
The App AutoUpdates and Restarts by itself, without any user interaction.

@vaenow
Copy link
Owner

vaenow commented Dec 19, 2017

@carlo318

Sorry, I cannot accept this PR.

Everyone has his own needs, so you must make Immediate update as an optional parameter.

* @param options An object that may contain the authentication options

Look forward to your next Pull Request 🙂

@carlo318
Copy link
Author

You are right, I have committed, in my branch, the version that suits my needs.
For sure, It's better to add a parameter.

But it seems not very clear to put this kind of parameter in authentication options.
Anyway, if you think it's fine to put it there, I will do it.
Thankyou.
Carlo

@carlo318
Copy link
Author

Please let me know if the new parameter skipPrompt is fine.
Thanks.

@ranaavneet89
Copy link

Hey guys!, Is this PR merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants