fix: prevent serialization to leak CurrentInstances #21277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollovati
force-pushed
the
fix/ui_deserialization_clean_currentinstances
branch
from
448783e to
deae901
Compare
During serialization and deserialization of VaadinSession and UI, CurrentInstances may be set but not present in the original instances map, causing the added instance to leak outside the scope of the deserialization hook method. This fix ensures all instances set by the hooks are wiped out before restoring the original instances.
mcollovati
force-pushed
the
fix/ui_deserialization_clean_currentinstances
branch
from
deae901 to
343acc2
Compare
mcollovati
changed the title
|
tepi
approved these changes
Apr 14, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 14, 2025
During serialization and deserialization of VaadinSession and UI, CurrentInstances may be set but not present in the original instances map, causing the added instance to leak outside the scope of the deserialization hook method. This fix ensures all instances set by the hooks are wiped out before restoring the original instances.
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 14, 2025
During serialization and deserialization of VaadinSession and UI, CurrentInstances may be set but not present in the original instances map, causing the added instance to leak outside the scope of the deserialization hook method. This fix ensures all instances set by the hooks are wiped out before restoring the original instances.
vaadin-bot
added a commit
that referenced
this pull request
Apr 14, 2025
During serialization and deserialization of VaadinSession and UI, CurrentInstances may be set but not present in the original instances map, causing the added instance to leak outside the scope of the deserialization hook method. This fix ensures all instances set by the hooks are wiped out before restoring the original instances. Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot
added a commit
that referenced
this pull request
Apr 14, 2025
During serialization and deserialization of VaadinSession and UI, CurrentInstances may be set but not present in the original instances map, causing the added instance to leak outside the scope of the deserialization hook method. This fix ensures all instances set by the hooks are wiped out before restoring the original instances. Co-authored-by: Marco Collovati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During serialization and deserialization of VaadinSession and UI,
CurrentInstances may be set but not present in the original instances map,
causing the added instance to leak outside the scope of the deserialization
hook method.
This fix ensures all instances set by the hooks are wiped out before
restoring the original instances.