-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QE: tidier action chain features #9813
base: master
Are you sure you want to change the base?
QE: tidier action chain features #9813
Conversation
👋 Hello! Thanks for contributing to our project. You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9813/checks If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
61b27c0
to
3e1b6ac
Compare
3e1b6ac
to
115c4bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one. There's something I don't like about the cucumber style, though.
Probably not your fault, it might come from someone else.
When I delete all action chains | ||
And I cancel all scheduled actions | ||
Scenario: Create a custom action chain for two systems | ||
When I call actionchain.create_chain() with chain label "two_systems_action_chain" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should avoid exposing internals.
Our cucumber text should look like English, not like a programming language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree.
I reused what was already there to see if the idea holds, but it would make sense to abstract these calls into another step.
Since I still have issues getting consistent results on the porting, I may have the time to refactor also this part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, the function calls inside cucumber text were already there - please just ignore, we can refactor later
What does this PR change?
Refactors the action chain related features in order to have each one of them use different names for different action chains.
Currently we reuse the same names over and over, both inside a single feature and between different features.
Switching to using different names allows to:
Also, currently some failures leave behind a chain with the same name of the one that is supposed to be freshly created, messing things up even more.
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
Cucumber tests were modified
DONE
Links
Issue(s):
Port(s):
4.3: https://github.com/SUSE/spacewalk/pull/26499
5.0:
DONE
Changelogs
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: