Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QE: tidier action chain features #9813

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NamelessOne91
Copy link
Contributor

@NamelessOne91 NamelessOne91 commented Feb 20, 2025

What does this PR change?

Refactors the action chain related features in order to have each one of them use different names for different action chains.
Currently we reuse the same names over and over, both inside a single feature and between different features.
Switching to using different names allows to:

  1. make the tests closer to what a customer will do
  2. make debugging a little bit easier
  3. possibly avoid testsuite failures due to sharing the same name for different chains - although that should be a non-issue, I have the impressions that if we schedule a bunch of commands, run and delete a chain, create another one with the same name, schedule more command (...) all in a short time span we might get into troubles as UI and internal serve state get out of sync.
    Also, currently some failures leave behind a chain with the same name of the one that is supposed to be freshly created, messing things up even more.
  4. possibly allow for parallelization if we can do without the step that cleanups previous actions/schedules

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • Cucumber tests were modified

  • DONE

Links

Issue(s):

Port(s):

Changelogs

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@NamelessOne91 NamelessOne91 requested a review from a team as a code owner February 20, 2025 12:52
@NamelessOne91 NamelessOne91 self-assigned this Feb 20, 2025
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕

You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9813/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9813/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@NamelessOne91 NamelessOne91 force-pushed the tidier_action_chain_features branch from 3e1b6ac to 115c4bb Compare February 21, 2025 15:27
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. There's something I don't like about the cucumber style, though.

Probably not your fault, it might come from someone else.

When I delete all action chains
And I cancel all scheduled actions
Scenario: Create a custom action chain for two systems
When I call actionchain.create_chain() with chain label "two_systems_action_chain"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid exposing internals.

Our cucumber text should look like English, not like a programming language.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree.
I reused what was already there to see if the idea holds, but it would make sense to abstract these calls into another step.
Since I still have issues getting consistent results on the porting, I may have the time to refactor also this part.

Copy link
Contributor

@ktsamis ktsamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no problem

@Bischoff Bischoff self-requested a review February 21, 2025 17:17
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, the function calls inside cucumber text were already there - please just ignore, we can refactor later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants