Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skipped status text color #8665

Merged
merged 8 commits into from
May 21, 2024
Merged

Fix skipped status text color #8665

merged 8 commits into from
May 21, 2024

Conversation

bisht-richa
Copy link
Contributor

What does this PR change?

  • Fixed skipped tasks and read messages color contrast in table

add description

GUI diff

No difference.

Before:

Screenshot 2024-04-25 at 16 08 39 Screenshot 2024-04-25 at 16 11 27

After:

Screenshot 2024-04-25 at 16 09 03 Screenshot 2024-04-25 at 16 09 33
  • DONE

Documentation

  • No documentation needed

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Issue(s): ##24136
Port(s): # add downstream PR(s), if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8665/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8665/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@Etheryte
Copy link
Member

While this fixes the contrast issue, the two types of entries are now practically indistinguishable, e.g. I can't tell that there's any difference between the rows in the after image. Is this intentional? If so, we might want to use some kind of a different indicator for these statuses.

@rjmateus
Copy link
Member

Maybe instead of having the text in a different color as before (which makes it hard to read), maybe we have have a full row with a different (maybe gray) color?

@bisht-richa
Copy link
Contributor Author

bisht-richa commented May 9, 2024

While this fixes the contrast issue, the two types of entries are now practically indistinguishable, e.g. I can't tell that there's any difference between the rows in the after image. Is this intentional? If so, we might want to use some kind of a different indicator for these statuses.

We already have open and closed envelop icons to show the two types of entries on the Notification page. And in another table, we have a clear indicator of Skipped status.
I don't know if we need more indicators here.

@Etheryte
Copy link
Member

Etheryte commented May 9, 2024

I don't have a strong opinion on how we indicate the status, however if we want to remove the muted text visual here, it would be more appropriate to remove the class from the elements, rather than override the style for it. Right now we override a style back to the base it already was.

@bisht-richa
Copy link
Contributor Author

bisht-richa commented May 9, 2024

For now:

  • I will remove the text-muted class from the tables. All text in the table will have a similar text visual.
  • For the status indicator we have the Status column in the runtime-status table and the Read column in the notification-messages table.
  • In text.scss and text.less file update color variable for text-muted class from eos-bc-gray-100 to eos-bc-gray-300 for better text visual.

Gray-100 is very light as a text color in the Light theme.

Gray-100


Screenshot 2024-05-13 at 10 27 09

Gray-300

Screenshot 2024-05-13 at 10 26 43 Screenshot 2024-05-09 at 13 36 05

@@ -0,0 +1,7 @@
// These are all leftovers from the old theme, hopefully we can drop most of this over time
.text-muted {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this if we're removing the class from the DOM? Same for the scss one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we still have use cases where we are using this class from scss file. But I will remove this text.less file I think we don't need it.

@admd admd merged commit 7fd9de6 into master May 21, 2024
25 checks passed
@admd admd deleted the fix-skipped-status-text-color branch May 21, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants