-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix skipped status text color #8665
Conversation
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
While this fixes the contrast issue, the two types of entries are now practically indistinguishable, e.g. I can't tell that there's any difference between the rows in the after image. Is this intentional? If so, we might want to use some kind of a different indicator for these statuses. |
Maybe instead of having the text in a different color as before (which makes it hard to read), maybe we have have a full row with a different (maybe gray) color? |
We already have |
I don't have a strong opinion on how we indicate the status, however if we want to remove the muted text visual here, it would be more appropriate to remove the class from the elements, rather than override the style for it. Right now we override a style back to the base it already was. |
@@ -0,0 +1,7 @@ | |||
// These are all leftovers from the old theme, hopefully we can drop most of this over time | |||
.text-muted { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this if we're removing the class from the DOM? Same for the scss one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we still have use cases where we are using this class from scss file. But I will remove this text.less file I think we don't need it.
What does this PR change?
add description
GUI diff
No difference.
Before:
After:
Documentation
No documentation needed
DONE
Test coverage
No tests: already covered
DONE
Links
Issue(s): ##24136
Port(s): # add downstream PR(s), if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!