Encode bytea fields #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjpmestre
force-pushed
the
encode_bytea_fields
branch
5 times, most recently
from
548b1d4
to
b9622ee
Compare
aaannz
requested changes
May 20, 2024
rjpmestre
force-pushed
the
encode_bytea_fields
branch
from
b9622ee
to
0af6bfa
Compare
aaannz
requested changes
May 20, 2024
rjpmestre
force-pushed
the
encode_bytea_fields
branch
from
0af6bfa
to
8b9da6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to fix https://github.com/SUSE/spacewalk/issues/23726
We detected a case where binary data contained backslashes. We've been using pq.QuoteLiteral but in these cases we end up getting invalid insert statements.
Besides, it also had some line breaks and contained sensitive information.
My suggestion here is to encode this type of data to hexadecimal as it would address the problems with escaping characters, keeps the statements tighter and also does not directly exposes any sensitive information that may be copied around servers.
We apply the same escape method to varchar fields. However i wanted to exclude them, at least for now. Encoding and decoding means having an additional processing overhead and this hasn't been a problem so far.