WIP: Add LBR_GRU to cell_fusion kernel for MTL dispatch #2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:gpu-intel
rjoursler
reviewed
Mar 12, 2025
| int eu_count = device_info.eu_count(); | ||
| int ideal_k_block = graph::utils::lcm( | ||
| eu_count, (int)device_info.min_subgroup_size()); | ||
| int ideal_k_limit = graph::utils::lcm(ideal_k_block, (int)rnn.sic); |
| ctx.rnn.bias[off_ker_bias(dims.dhc, 0, c)], | ||
| ctx.rnn.alpha, ctx.rnn.tm_scales); | ||
| store_vanilla_rnn(gates.ptr, gates.strides.mb, states.ptr, | ||
| states.strides.mb, dims.dhc, n, c, g); |
There was a problem hiding this comment.
Please keep the runtime if statements so that we get compiler tests on all cases during development.
| * TO_REF( | ||
| ctx.lbr_gru.hidden_state_iter[cell_ws_state( | ||
| states.strides.mb, n, c)]) | ||
| + (1 - G0) * G2; |
There was a problem hiding this comment.
Please wrap the Ht calculation into compute_gates_lbr_gru., we can then just get rid of all these intermediate variables.
Additionally, please update elemwise_fwd to use compute_gates_lbr_gru to avoid code duplication.
rjoursler
reviewed
Mar 12, 2025
| } | ||
|
|
||
| status_t compute_cell_fwd(const exec_ctx_t &ctx, | ||
| const compute::kernel_t &kernel, dim_t lay, dim_t dir, dim_t iter, |
There was a problem hiding this comment.
Rather than duplicate this function, can we reasonably create a shared implementation between cell_common and this one.?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This WIP PR has a few things left:
Fixes # (MFDNN-12712)