Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph: interface: several fixes and code improves #2863

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

TaoLv
Copy link
Contributor

@TaoLv TaoLv commented Mar 12, 2025

  1. JSON file serialization: removed the trailing whitespaces which may cause unintended edits when a JSON file is opened and closed with an editor (eg. vscode) configured with removing trailing whitespaces. Also added a newline at the end of the JSON file.
  2. Moved the graph::serialize() method to cpp file so changing it or the JSON utility will not cause the whole graph component recompile (due to graph.hpp is almost included everywhere).
  3. Backend interface: removed two lock guards which seem unnecessary.
  4. fpmath_t: make the constructor explicit so we don't confuse it with fpmath_mode_t. At some places, we passed fpmath_mode_t to functions which requires fpmath_t as an argument.

@TaoLv TaoLv requested a review from a team as a code owner March 12, 2025 06:04
@github-actions github-actions bot added component:graph-api Codeowner: @oneapi-src/onednn-graph component:tests Codeowner: @oneapi-src/onednn-arch labels Mar 12, 2025
@TaoLv TaoLv force-pushed the lvtao/main/fixes-1 branch from 5362453 to 2ee03b6 Compare March 13, 2025 06:38
@TaoLv TaoLv requested a review from a team as a code owner March 13, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:graph-api Codeowner: @oneapi-src/onednn-graph component:tests Codeowner: @oneapi-src/onednn-arch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant