ukernel: add a common shim layer for better maintainability and split x64 APIs and abstractions into several files #2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:cpu-x64
6 tasks
|
make test |
dzarukin
changed the title
Radu2k
approved these changes
Mar 13, 2025
Comment on lines
+27
to
+29
| #define VCHECK_BRGEMM(cond, msg, ...) \ | ||
| VCONDCHECK(ukernel, create, check, brgemm, (cond), \ | ||
| status::invalid_arguments, msg, ##__VA_ARGS__) |
There was a problem hiding this comment.
I think we should move this in the corresponding BRGeMM file and import it here as this is a BRGEMM check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common shim layer should allow to modify existing or introduce new APIs without updating all backends but just the one desired.
With current model every change to API forces a developer to update all backends, otherwise, a compilation or linking failure will pop up.
Splitting x64 abstractions follows primitive abstraction coding practice.