Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces support for 3D and 4D inputs in ACL acl_lowp and acl_lowp_sq matmul. #2846

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renato-arantes
Copy link
Contributor

Description

This PR introduces 3D and 4D support for acl_lowp_matmul_t and acl_lowp_sq_matmul_t in ACL. Solves issue.

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?
  • Have you submitted performance data that demonstrates performance improvements?

Performance improvements

Below are small test case logs that demonstrate performance numbers before and after.

  • 3D lowp:

OMP_NUM_THREADS=16 ./tests/benchdnn/benchdnn --mode=pc --matmul --dt=s8:s8:f32 4x1024x1024:1x1024x1024

ACL: total perf: min(ms):1.53076 avg(ms):1.55271
JIT: total perf: min(ms):1029.39 avg(ms):1029.92

  • 3D lowp_sq:

OMP_NUM_THREADS=16 ./tests/benchdnn/benchdnn --mode=pc --matmul --dt=s8:s8:s8 4x1024x1024:1x1024x1024

ACL: total perf: min(ms):1.38965 avg(ms):1.4086
JIT: total perf: min(ms):1032.73 avg(ms):1033.18

  • 4D lowp:

OMP_NUM_THREADS=16 ./tests/benchdnn/benchdnn --mode=pc --matmul --dt=s8:s8:f32 4x4x1024x1024:1x1x1024x1024

ACL: total perf: min(ms):5.95874 avg(ms):5.9957
JIT: total perf: min(ms):4003.9 avg(ms):4005.17

  • 4D lowp_sq:

OMP_NUM_THREADS=16 ./tests/benchdnn/benchdnn --mode=pc --matmul --dt=s8:s8:s8 4x4x1024x1024:1x1x1024x1024

ACL: total perf: min(ms):5.31323 avg(ms):5.34218
JIT: total perf: min(ms):4022.92 avg(ms):4023.37

@renato-arantes renato-arantes requested a review from a team as a code owner March 10, 2025 10:02
@github-actions github-actions bot added the platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 label Mar 10, 2025
@renato-arantes renato-arantes force-pushed the lowp_3d4d branch 2 times, most recently from 63b33f5 to 24143ab Compare March 13, 2025 09:44
@renato-arantes renato-arantes requested a review from a team as a code owner March 13, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant