[GPU] Periodic Coverity roundup #2840
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:gpu-intel
| @@ -212,7 +212,7 @@ atomic_reduction_conf_t::atomic_reduction_conf_t( | |||
| status_t atomic_reduction_conf_t::init_dispatcher( | |||
| const compute::compute_engine_t *engine, | |||
| const gpu_primitive_attr_t *gpu_attr) { | |||
| const std::vector<dim_idx_t> dispatch_dims = { | |||
| std::vector<dim_idx_t> dispatch_dims = { | |||
There was a problem hiding this comment.
just curious why drop const?
There was a problem hiding this comment.
The other change in this file std::moves this vector to prevent a copy. With the const, std::move has no effect, and we would still get a copy.
kealan-barbieri
approved these changes
Mar 7, 2025
atkassen
force-pushed
the
akassen/coverity
branch
from
c1caff6 to
c159499
Compare
atkassen
force-pushed
the
akassen/coverity
branch
from
c159499 to
7bd3419
Compare
|
make test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses most low severity Coverity hits for GPU and GEMM components.