-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding REDIS support #10
base: master
Are you sure you want to change the base?
Conversation
Hey @AndrewEastwood |
So if you switch to Redis and configure php to use redis as session storage then you can easily scale your app by adding nodes where each node will be looking into redis for active sessions :) |
Sorry I've been taking so long to get to this... the only concern that I have is that changes that have been made directly to PHPCAS. PHPCAS is a dependency of the project and is really only vendored in to the project for the sake of having it included in the wordpress.org plugin repository so it doesn't have to be built in when the plugin is installed. |
@AndrewEastwood just following up... Do you think it would be possible to extract these changes from PHPCAS as mentioned above? I'd love to be able to merge this in. |
@gpspake, yeah, I can transfer those change into a new PR for the PHPCAS. I just have a concern if they reject my changes then what will we do? |
Hey @gpspake! I moved all changes to the phpCAS repo. Let's wait for the @jfritschi's response. |
Awesome! good luck, let's hope it gets pulled. Worst case, they may at least provide an explanation for why they wouldn't merge it in. We've actually been discussing using Redis with CAS. Let's see what happens with that PR and go from there |
Also I added more options.