Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser origin location was not forwarded properly #2037

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PieterOlivier
Copy link
Contributor

The parse function has an extra parameter in case the origin was not the same as the input location. But the origin was never properly passed on.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49%. Comparing base (fc72dc7) to head (e39e494).

Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2037   +/-   ##
=======================================
  Coverage       49%     49%           
  Complexity    6306    6306           
=======================================
  Files          664     664           
  Lines        59635   59635           
  Branches      8647    8647           
=======================================
+ Hits         29471   29477    +6     
+ Misses       27946   27940    -6     
  Partials      2218    2218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavyLandman
Copy link
Member

@jurgenvinju do you remember if this was intentional? it seems to me like a small bug, but there might have been an explicit reason for it to ignore that origin parameter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants