Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secdist parameters (user, password, secure_connection_cert) to ydb #768

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ydb/src/ydb/impl/config.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ DriverSettings ParseDriverSettings(
result.endpoint = MergeWithSecdist(dbsecdist.endpoint, std::move(config_endpoint), dbconfig, "endpoint");
result.database = MergeWithSecdist(dbsecdist.database, std::move(config_database), dbconfig, "database");
result.oauth_token = dbsecdist.oauth_token;
result.secure_connection_cert = dbsecdist.secure_connection_cert;
result.user = dbsecdist.user;
result.password = dbsecdist.password;
if (dbsecdist.iam_jwt_params.has_value()) {
result.iam_jwt_params = formats::json::ToString(dbsecdist.iam_jwt_params.value());
}
Expand Down
3 changes: 3 additions & 0 deletions ydb/src/ydb/impl/config.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ struct DriverSettings {
bool prefer_local_dc{false};
std::optional<std::string> oauth_token;
std::optional<std::string> iam_jwt_params;
std::optional<std::string> secure_connection_cert;
std::optional<std::string> user;
std::optional<std::string> password;
std::shared_ptr<NYdb::ICredentialsProviderFactory> credentials_provider_factory;
};

Expand Down
9 changes: 9 additions & 0 deletions ydb/src/ydb/impl/driver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#include <ydb-cpp-sdk/client/driver/driver.h>
#include <ydb-cpp-sdk/client/extensions/solomon_stats/pull_connector.h>
#include <ydb-cpp-sdk/client/iam/iam.h>
#include <ydb-cpp-sdk/client/types/credentials/credentials.h>

#include <userver/utils/algo.hpp>
#include <userver/utils/text_light.hpp>
Expand All @@ -27,6 +28,10 @@ Driver::Driver(std::string dbname, impl::DriverSettings settings)
: NYdb::EBalancingPolicy::UseAllNodes
);

if (settings.secure_connection_cert.has_value()) {
driver_config.UseSecureConnection(settings.secure_connection_cert->data());
}

if (settings.credentials_provider_factory) {
driver_config.SetCredentialsProviderFactory(settings.credentials_provider_factory);
} else if (settings.oauth_token.has_value()) {
Expand All @@ -35,6 +40,10 @@ Driver::Driver(std::string dbname, impl::DriverSettings settings)
driver_config.UseSecureConnection().SetCredentialsProviderFactory(
NYdb::CreateIamJwtParamsCredentialsProviderFactory({.JwtContent = settings.iam_jwt_params->data()})
);
} else if (settings.user.has_value() && settings.password.has_value()) {
driver_config.SetCredentialsProviderFactory(NYdb::CreateLoginCredentialsProviderFactory(
{.User = settings.user->data(), .Password = settings.password->data()}
));
}

driver_ = std::make_unique<NYdb::TDriver>(driver_config);
Expand Down
3 changes: 3 additions & 0 deletions ydb/src/ydb/impl/secdist.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ DatabaseSettings GetDatabaseSettings(const formats::json::Value& doc) {
settings.endpoint = doc["endpoint"].As<std::optional<std::string>>();
settings.database = doc["database"].As<std::optional<std::string>>();
settings.sync_start = doc["sync_start"].As<std::optional<bool>>();
settings.secure_connection_cert = doc["secure_connection_cert"].As<std::optional<std::string>>();
settings.user = doc["user"].As<std::optional<std::string>>();
settings.password = doc["password"].As<std::optional<std::string>>();
if (doc.HasMember("token")) {
settings.oauth_token = doc["token"].As<std::string>();
} else if (doc.HasMember("iam_jwt_params")) {
Expand Down
3 changes: 3 additions & 0 deletions ydb/src/ydb/impl/secdist.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ struct DatabaseSettings final {
std::optional<std::string> endpoint;
std::optional<std::string> database;
std::optional<std::string> oauth_token;
std::optional<std::string> secure_connection_cert;
std::optional<std::string> user;
std::optional<std::string> password;
std::optional<formats::json::Value> iam_jwt_params;
std::optional<bool> sync_start;
};
Expand Down
Loading