File tree Expand file tree Collapse file tree 3 files changed +12
-5
lines changed
include/userver/utils/statistics Expand file tree Collapse file tree 3 files changed +12
-5
lines changed Original file line number Diff line number Diff line change 77#include < string_view>
88#include < type_traits>
99
10+ #include < userver/utils/assert.hpp>
11+
1012USERVER_NAMESPACE_BEGIN
1113
1214namespace utils ::statistics {
@@ -16,10 +18,12 @@ class Label;
1618// / @brief Non owning label name+value storage.
1719class LabelView final {
1820public:
19- LabelView () = default ;
21+ LabelView () = delete ;
2022 LabelView (Label&& label) = delete ;
21- explicit LabelView (const Label& label) noexcept ;
22- constexpr LabelView (std::string_view name, std::string_view value) noexcept : name_(name), value_(value) {}
23+ explicit LabelView (const Label& label);
24+ constexpr LabelView (std::string_view name, std::string_view value) : name_(name), value_(value) {
25+ UINVARIANT (!name_.empty (), " The lable name must not be empty." );
26+ }
2327
2428 template <class T , std::enable_if_t <std::is_arithmetic_v<T>>* = nullptr >
2529 constexpr LabelView (std::string_view, T) {
Original file line number Diff line number Diff line change @@ -6,7 +6,9 @@ USERVER_NAMESPACE_BEGIN
66
77namespace utils ::statistics {
88
9- LabelView::LabelView (const Label& label) noexcept : name_(label.Name()), value_(label.Value()) {}
9+ LabelView::LabelView (const Label& label) : name_(label.Name()), value_(label.Value()) {
10+ UINVARIANT (!name_.empty (), " The lable name must not be empty." );
11+ }
1012
1113LabelsSpan::LabelsSpan (const LabelView* begin, const LabelView* end) noexcept : begin_(begin), end_(end) {
1214 UASSERT (begin <= end);
Original file line number Diff line number Diff line change @@ -201,7 +201,8 @@ void Writer::ResetState() noexcept {
201201 kFixitHint
202202 )
203203 );
204- state_->add_labels .resize (initial_labels_size_);
204+ auto & labels = state_->add_labels ;
205+ labels.erase (labels.begin () + initial_labels_size_, labels.end ());
205206
206207 state_ = nullptr ;
207208}
You can’t perform that action at this time.
0 commit comments