hotfix(builder): add preset length validation #1705
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preset length was not being validated, this causes that when generating the variant for publishing to the registry it can end up being more than 32bytes. Luckily, this fix is not going to break any already published package as the current preset max length published is
24bytes
.This is the original error that was being thrown when trying to pin/publish:
And now, with the fix it doesn't even allow you to build the package:
