fix: oauth2 tokenHeaderPrefix can be set to an empty string value #4928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted as the auth type for the first time ~ check if tokenPrefix is present before adding a space before the access_token value in the header
lohxt1
requested review from
helloanoop,
maintainer-bruno,
lohit-bruno and
naman-bruno
as code owners
naman-bruno
previously approved these changes
Jun 24, 2025
maintainer-bruno
requested changes
Jun 25, 2025
naman-bruno
previously approved these changes
Jun 26, 2025
lohxt1
force-pushed
the
empty_token_prefix_issue
branch
from
54032a6 to
f6615ee
Compare
naman-bruno
approved these changes
Jun 26, 2025
maintainer-bruno
approved these changes
Jun 26, 2025
naman-bruno
pushed a commit
to naman-bruno/bruno
that referenced
this pull request
Jun 26, 2025
…ebruno#4928) * ~ only prefill `Bearer` as token prefix only when the oauth2 is selected as the auth type for the first time ~ check if tokenPrefix is present before adding a space before the access_token value in the header * review comment fixes --------- Co-authored-by: lohit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes: #4873
Jira
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.