Make pre-request scripts operate on completely prepared request #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pre-request script phase is now executed after configureRequest. That means the 'req' object in pre-request script has access to more data, including evaluated variables, set authorization headers, etc. fixes usebruno#2249
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pre-request script phase is now executed after configureRequest. That means the 'req' object in pre-request script has access to more data, including evaluated variables, set authorization headers, etc.
fixes #2249
Makes sense especially if #2061 / #2077 are to be accepted, because this would allow to access OAuth2 credentials after they are obtained, but before sending actual user request.
Contribution Checklist: