Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: handling invalid import environment names (#2197) #2214

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

busy-panda
Copy link

@busy-panda busy-panda commented May 1, 2024

Fixes: #2197
Fixes: #1761

Description

This change apply a similar fix that was done for collection import (PR #242).
Any illegal character in filename is replaced automatically by a "-" character.
So we are consistent between environment import and collection import.

import.environment.mp4

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@busy-panda busy-panda marked this pull request as ready for review May 1, 2024 10:22
@igor-topolski
Copy link

I think rather than trying to fix the issue for the user in an unexpected way, it's better to display a more descriptive error (as per my other PR you commented on, see: #2200).

If a user were to have two environments (Some / Environment and Some \ Environment), this approach would only delay the issue - the first one will succeed, while the second one will fail due to the name existing already.

From a user perspective, I'd rather have the privilege of resolving the naming issue myself instead of having the application change the naming for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants