Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: response panel split horizontal #2194

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

busy-panda
Copy link

@busy-panda busy-panda commented Apr 28, 2024

Description

Resolves: #1041

With this change:

  • it is now possible to split the request/response panels vertically or horizontally
  • vertical overflows have been adjusted in all screens in both horizontal and vertical layouts
  • the split direction is persisted as a user preference
  • it is now more comfortable to work with Bruno and an IDE open at the same time on the same screen

Here is the demo:

electron_RMZzCLPpFU.mp4

And more screenshots:

image

electron_U8PIxmHYom electron_YTFmzaYsHH electron_cOgYuTtQCI electron_YOffgENlxT electron_f5VDlymJQc electron_u8mcHJ51zw electron_jkmnd8Zser electron_2qc7UtuoZC electron_kxt7gTU7dM electron_ZQQX7NEcb4 electron_C89wxtWqQB electron_x1yFSWnCvf electron_BfG0s59HkF electron_Kcf44IA8Pc electron_UmydaeGYrB electron_k2F3JkxjPb electron_OEs0egUkL2 electron_qk5S9XxK2Q

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@Its-treason
Copy link
Member

Its-treason commented Apr 28, 2024

Hey small thing, instead of opening a new PR every time you squash your commits, you can just rebase your branch and then force push. This way you don't have to open & close your PR's.

@busy-panda
Copy link
Author

Hey small thing, instead of opening a new PR every time you squash your commits, you can just rebase your branch and then force push. This way you don't have to open & close your PR's.

Ok sorry about that, I will do like you suggest next times

@busy-panda busy-panda force-pushed the feature/1041-response-panel-split-horizontal branch from 3967588 to 3a08877 Compare April 29, 2024 14:38
@busy-panda busy-panda changed the title Feature/response panel split horizontal 1041 (#1) feature: response panel split horizontal Apr 29, 2024
@busy-panda busy-panda marked this pull request as ready for review April 29, 2024 15:25
@busy-panda
Copy link
Author

Sorry for making more changes to my PR recently, but I am now happy with my changes, I am confident it works because I went through all screens to verify the display.
So I am done, I am not making anymore changes.

@reorx
Copy link

reorx commented Apr 30, 2024

looking forward to seeing this one merged

@daniel9x
Copy link

looking forward to seeing this one merged

Same!!

@busy-panda
Copy link
Author

Hi @sanjai0py, would you be able by any chance to assign the PR to someone for review ?
Cheers

@busy-panda
Copy link
Author

busy-panda commented May 6, 2024

Hi @Its-treason Would you have the chance to review this PR, currently it's not assigned to anyone

@Its-treason
Copy link
Member

I can review your PR in the next few days. But your PR is quite big, so it will take some time to review.

But before I start reviewing this, I would like for @helloanoop to confirm that: We want this, and it gets merged soon after reviewing.

@busy-panda
Copy link
Author

busy-panda commented May 6, 2024

Just to explain why this change is pretty important for me and certainly others.

If you put side by side your ide and bruno, you have very narrow columns for request and response in bruno, see below my screen

image

And lucky me, I have a pretty wide screen...

@helloanoop helloanoop self-assigned this May 7, 2024
@helloanoop
Copy link
Contributor

@busy-panda This is something that we definetely want to get merged.

One of the concerns I have merging a large PR like this is that it would also need extensive testing before we ship the build as we do not want to break the interface for the current vertical split (like the code editor heights)

Also, there is a large number of other PR's that rank higher in priority.
I will come back to this in about 1-2 weeks. Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] UI: Response Panel Split Horizontally
5 participants