Comments #7
Open
Comments #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
u3ks
reviewed
Oct 3, 2024
There was a problem hiding this comment.
yea and the buffer we use for the fuzzy contiguity is set to be higher than the simplification tolerance
u3ks
reviewed
Oct 3, 2024
|
|
||
| ### drop any remaining duplicates | ||
| ## sometimes -1s have multiple tesselation cells | ||
| tessellation = tessellation[~tessellation.index.duplicated()].sort_index() | ||
| # are they identical or have identical id? |
There was a problem hiding this comment.
Then we should keep all geoms and remap ids, no?
u3ks
reviewed
Oct 3, 2024
|
|
||
| # drop empty spaces with no buildings and a positive index, | ||
| # leave negatives in the geodataframe | ||
| tessellation = tessellation.explode() | ||
| inp, res = buildings.geometry.centroid.sindex.query(tessellation.geometry) | ||
| to_keep = np.append(np.unique(inp), np.where(tessellation.index.values < 0)[0]) | ||
| tessellation = tessellation.iloc[to_keep] | ||
| # why does this happen? |
There was a problem hiding this comment.
this means that a tessellation cell can potentially span across two enclosures? doesn't it break stuff?
yes, I think i put it there because sometimes it happens due to weird enclosure shapes, so I try to drop the parts that dont have buildings in them otherwise it results in a werid topology where two ETCs that are far away from each other might be neighbours
i'll have to find a specific example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not to be merged but it contains my comments and questions.
So far for primary characters generation pipeline. All characters look correct!