Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up relic dependencies #219

Merged
merged 4 commits into from
Dec 10, 2024
Merged

clean up relic dependencies #219

merged 4 commits into from
Dec 10, 2024

Conversation

jGaboardi
Copy link
Collaborator

@jGaboardi jGaboardi commented Dec 7, 2024

This PR:

Copy link
Collaborator

@anastassiavybornova anastassiavybornova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pixi.lock env : i tried it out (with the neatnet notebook) and it's working for me!
  • pyproject.toml: i guess some of packages currently removed by this PR should stay if we stick to what martin suggests here revisit required Python & dependencies #204 ?

@jGaboardi
Copy link
Collaborator Author

I'll update based on new decisions

@jGaboardi
Copy link
Collaborator Author

Yeah... I tried to clean up merge conflicts in the pixi.lock file. Did not go well.

@jGaboardi
Copy link
Collaborator Author

I hope I did this correctly. I'm still very in the dark with the new pixi stuff.

Copy link
Collaborator

@anastassiavybornova anastassiavybornova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so i re-tried with the new pixi environment, and it seems to be working for me, osmnx notebook runs for all cities, and the neatnet simplification notebook worked for aleppo AND wuhan (is this weird or expected? given uscuni/neatnet#149 )

@martinfleis martinfleis merged commit 317ff5b into main Dec 10, 2024
5 checks passed
@martinfleis martinfleis deleted the GH207_review_deps branch December 10, 2024 11:33
@martinfleis
Copy link
Contributor

I am able to reproduce uscuni/neatnet#149 with this PR. I suppose it is some pesky Apple Silicon issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

revisit required Python & dependencies
3 participants