Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source nodes.py from sgeop #196

Merged
merged 2 commits into from
Nov 21, 2024
Merged

source nodes.py from sgeop #196

merged 2 commits into from
Nov 21, 2024

Conversation

jGaboardi
Copy link
Collaborator

This PR:

  • continues add sgeop as a dependency -- transfer functionality #177
  • remove simplification/algorithms/nodes.py
  • sources functionality from sgeop. nodes.py
  • updates codebase & notebooks/typology/*
  • Seems no other notebooks affected
  • Did not touch notebooks/archive/* – Let me know if yall want me to update those.

@jGaboardi jGaboardi self-assigned this Nov 20, 2024
@jGaboardi jGaboardi mentioned this pull request Nov 20, 2024
Closed
6 tasks
@jGaboardi jGaboardi merged commit c3e04c3 into main Nov 21, 2024
2 checks passed
@jGaboardi jGaboardi deleted the GH177_source_nodes_from_sgeop branch November 21, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfleis martinfleis martinfleis approved these changes

@anastassiavybornova anastassiavybornova Awaiting requested review from anastassiavybornova

Assignees

@jGaboardi jGaboardi

Labels
DRY housekeeping
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jGaboardi @martinfleis