Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dedicated minimal tests -- nodes.induce_nodes() #67

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

jGaboardi
Copy link
Collaborator

This PR:

@jGaboardi jGaboardi self-assigned this Oct 25, 2024
@jGaboardi jGaboardi mentioned this pull request Oct 25, 2024
5 tasks
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.3%. Comparing base (dc4324f) to head (5673be6).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #67   +/-   ##
=====================================
  Coverage   98.3%   98.3%           
=====================================
  Files          6       6           
  Lines        894     897    +3     
=====================================
+ Hits         879     882    +3     
  Misses        15      15           
Files with missing lines Coverage Δ
sgeop/nodes.py 98.8% <100.0%> (+<0.1%) ⬆️

@jGaboardi
Copy link
Collaborator Author

  • Culprit appears to be shapely=2.1.0.dev0+134.g3873635 vs. shapely=2.1.0.dev0+135.g81adc3f
  • Not sure if failures are due to precision errors. Seems likely, but will investigate.

Failing

SYSTEM INFO
-----------
python     : 3.12.7 | packaged by conda-forge | (main, Oct  4 2024, 16:05:46) [GCC 13.3.0]
executable : /home/runner/micromamba/envs/py312_sgeop-dev/bin/python
machine    : Linux-6.5.0-1025-azure-x86_64-with-glibc2.35

GEOS, GDAL, PROJ INFO
---------------------
GEOS       : 3.13.0
GEOS lib   : None
GDAL       : 3.9.1
GDAL data dir: /home/runner/micromamba/envs/py312_sgeop-dev/lib/python3.12/site-packages/pyogrio/gdal_data/
PROJ       : 9.4.1
PROJ data dir: /home/runner/micromamba/envs/py312_sgeop-dev/lib/python3.12/site-packages/pyproj/proj_dir/share/proj

PYTHON DEPENDENCIES
-------------------
geopandas  : 1.0.1+35.g553fabe
numpy      : 2.1.2
pandas     : 2.2.3
pyproj     : 3.7.0
shapely    : 2.1.0.dev0+135.g81adc3f
pyogrio    : 0.10.0
geoalchemy2: None
geopy      : None
matplotlib : None
mapclassify: None
fiona      : None
psycopg    : None
psycopg2   : None
pyarrow    : 18.0.0

Last passing

SYSTEM INFO
-----------
python     : 3.12.7 | packaged by conda-forge | (main, Oct  4 2024, 16:05:46) [GCC 13.3.0]
executable : /home/runner/micromamba/envs/py312_sgeop-dev/bin/python
machine    : Linux-6.5.0-1025-azure-x86_64-with-glibc2.35

GEOS, GDAL, PROJ INFO
---------------------
GEOS       : 3.13.0
GEOS lib   : None
GDAL       : 3.9.1
GDAL data dir: /home/runner/micromamba/envs/py312_sgeop-dev/lib/python3.12/site-packages/pyogrio/gdal_data/
PROJ       : 9.4.1
PROJ data dir: /home/runner/micromamba/envs/py312_sgeop-dev/lib/python3.12/site-packages/pyproj/proj_dir/share/proj

PYTHON DEPENDENCIES
-------------------
geopandas  : 1.0.1+35.g553fabe
numpy      : 2.1.2
pandas     : 2.2.3
pyproj     : 3.7.0
shapely    : 2.1.0.dev0+134.g3873635
pyogrio    : 0.10.0
geoalchemy2: None
geopy      : None
matplotlib : None
mapclassify: None
fiona      : None
psycopg    : None
psycopg2   : None
pyarrow    : 18.0.0

@martinfleis
Copy link
Contributor

The shapely difference makes sense as it now uses GEOS to get the polylabel.

@jGaboardi
Copy link
Collaborator Author

jGaboardi commented Nov 5, 2024

@martinfleis Do you have anything against this getting merged? It's a minor refactor, but will help to get massaged into #76 and the GH69_tweaking_loop_logic branch.

We can discuss the dev failures in #75

@martinfleis martinfleis merged commit e8ce601 into main Nov 6, 2024
9 of 10 checks passed
@martinfleis martinfleis deleted the GH20_nodes_tests_induce_nodes branch November 6, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants