chip away some refactors in geometry.py
#46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
=====================================
Coverage 98.1% 98.1%
=====================================
Files 6 6
Lines 880 891 +11
=====================================
+ Hits 863 874 +11
Misses 17 17
|
martinfleis
reviewed
Oct 17, 2024
| @@ -236,7 +237,7 @@ def voronoi_skeleton( | |||
| if edgelines.shape[0] > 0: | |||
| # if there is no explicit snapping target, snap to the boundary of the polygon | |||
| # via the shortest line. That is by definition always within the polygon | |||
| # (Martin thinks) | |||
| # (Martin thinks) (James concurs) | |||
sgeop/geometry.py
Outdated
Comment on lines
404
to
406
| def _last_point(line: shapely.LineString) -> shapely.Point: | ||
| """Helper for returning final point on a line.""" | ||
| return shapely.get_point(line, -1) |
There was a problem hiding this comment.
I'd probably prefer using shapely.get_point(line, -1) and it is explicit
There was a problem hiding this comment.
I've got no problem with that. I'll dump that helper and remove from testing.
martinfleis
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
geometry.pygeometry.snap_to_targets()& breaks out some helper funds