first round `geometry.voronoi_skeleton()` tests #27

jGaboardi · 2024-10-06T04:05:21Z

This PR:

provide an initial round of geometry.voronoi_skeleton() tests
xref:

jGaboardi · 2024-10-06T04:23:52Z

sgeop/geometry.py

+    snap_to : None | gpd.GeoSeries = None
+        Series of geometries that shall be connected to the skeleton.
+    max_segment_length: int = 1
+        ...
    distance : float


Additional vertices will be added so that all line segments are no longer than this value. Must be greater than 0.

sgeop/tests/test_geometry.py

jGaboardi · 2024-10-06T04:32:09Z

@martinfleis Do we think I should:

spend more time adapting tests for minimum geopandas
skip some minimum geopandas tests
bump minimum geopandas version

martinfleis · 2024-10-06T14:24:29Z

I have no clue where the issue comes from but I'd bump minimum versions to whatever works. We don't need to service legacy code here.

jGaboardi · 2024-10-06T17:52:24Z

README.md

@@ -1,6 +1,6 @@
 # `sgeop`: Street Geometry Processing Toolkit

-[![Continuous Integration](https://github.com/uscuni/sgeop/actions/workflows/testing.yml/badge.svg)](https://github.com/uscuni/sgeop/actions/workflows/testing.yml)
+[![Continuous Integration](https://github.com/uscuni/sgeop/actions/workflows/testing.yml/badge.svg)](https://github.com/uscuni/sgeop/actions/workflows/testing.yml) [![codecov](https://codecov.io/gh/uscuni/sgeop/branch/main/graph/badge.svg?token=VNn0WR5JWT)](https://codecov.io/gh/uscuni/sgeop)


I have requested access to configure codecov.io for the uscuni/sgeop repo. Not sure if a notification was sent to you or not @martinfleis ?

Still nothing showing up. 99% sure it's because I am not listed as a member of the uscuni organization (and that's why we couldn't work it out for simplification either). Can you add me there and we'll see if that takes care of it?

I think this is done. If not, please send me the link where I need to click something.

jGaboardi · 2024-10-07T01:49:37Z

Something in this PR leads to the following failure:

 1038 # skeletonize
-> 1039 skel, _ = voronoi_skeleton(
   1040     skeletonization_input,
   1041     cluster_geom,
   1042     snap_to=False,
   1043     max_segment_length=max_segment_length,
   1044     limit_distance=1e-4,
   1045     consolidation_tolerance=consolidation_tolerance,
   1046 )
   1048 # if we used only segments, we need to remove dangles
   1049 if len(connection) == 1:

Need to be running a full sgeop.simplify() call in testing (even if not explicitly testing anything yet), just to make sure it passes.

jGaboardi · 2024-10-12T18:39:32Z

OK, @martinfleis – this is now ready for review.

martinfleis · 2024-10-15T07:24:45Z

README.md

@@ -1,6 +1,6 @@
 # `sgeop`: Street Geometry Processing Toolkit

-[![Continuous Integration](https://github.com/uscuni/sgeop/actions/workflows/testing.yml/badge.svg)](https://github.com/uscuni/sgeop/actions/workflows/testing.yml)
+[![Continuous Integration](https://github.com/uscuni/sgeop/actions/workflows/testing.yml/badge.svg)](https://github.com/uscuni/sgeop/actions/workflows/testing.yml) [![codecov](https://codecov.io/gh/uscuni/sgeop/branch/main/graph/badge.svg?token=VNn0WR5JWT)](https://codecov.io/gh/uscuni/sgeop)


I think this is done. If not, please send me the link where I need to click something.

martinfleis · 2024-10-15T07:26:19Z

sgeop/geometry.py

+    snap_to : None | gpd.GeoSeries = None
+        Series of geometries that shall be connected to the skeleton.
+    max_segment_length: int = 1
+        ...
    distance : float


Additional vertices will be added so that all line segments are no longer than this value. Must be greater than 0.

sgeop/geometry.py

sgeop/tests/conftest.py

martinfleis · 2024-10-15T07:29:20Z

sgeop/tests/conftest.py

+        else:
+            return _poly
+    else:
+        return shapely.polygonize(collection).buffer(0)


shapely.make_valid() is not fixing the problem locally (perhaps solution in current dev) -- still need .buffer(0)

Without .buffer(0) still seeing:

FAILED sgeop/tests/test_geometry.py::TestVoronoiSkeleton::test_square[array-True-0.1] - AttributeError: 'GeometryCollection' object has no attribute 'exterior' FAILED sgeop/tests/test_geometry.py::TestVoronoiSkeleton::test_square_snap_to[list-True-0.001] - AttributeError: 'GeometryCollection' object has no attribute 'exterior' FAILED sgeop/tests/test_geometry.py::TestVoronoiSkeleton::test_square[list-True-0.001] - AttributeError: 'GeometryCollection' object has no attribute 'exterior' FAILED sgeop/tests/test_geometry.py::TestVoronoiSkeleton::test_square_snap_to[array-True-0.1] - AttributeError: 'GeometryCollection' object has no attribute 'exterior'

martinfleis

Alright, let's give this a go.

first round voronoi_skeleton() tests

32f40b3

jGaboardi self-assigned this Oct 6, 2024

jGaboardi added the tests/CI label Oct 6, 2024

jGaboardi mentioned this pull request Oct 6, 2024

testing, refactor, & docstrings #20

Closed

5 tasks

gpd leq 1 testing polygonize

c3436ca

jGaboardi commented Oct 6, 2024

View reviewed changes

sgeop/tests/test_geometry.py Show resolved Hide resolved

bumpy min geopandas=0.14

3a397d9

jGaboardi added 7 commits October 6, 2024 12:00

update min reqs & pin all in oldest CI

dc1c986

update min reqs & pin all in oldest CI [2]

eda9cc8

break out _remove_sliver() func + test

8e0657c

add codecov - update README

99fd409

break out _as_parts() func + test

352b6e3

break out _consolidate() func + test

5de5e9f

remove unused internal func in conftest.polygonize()

f978235

jGaboardi commented Oct 6, 2024

View reviewed changes

jGaboardi requested a review from martinfleis October 6, 2024 17:56

jGaboardi added the refactor & code maint label Oct 6, 2024

jGaboardi removed the request for review from martinfleis October 7, 2024 01:46

jGaboardi marked this pull request as draft October 7, 2024 01:47

This was referenced Oct 7, 2024

small testing data for full algo run #28

Closed

small integrated testing data - apalachicola, fl #29

Merged

jGaboardi added 4 commits October 7, 2024 16:11

merge origin/main

b74e6a5

Merge branch 'main' into GH20_geometry_tests

0328025

Merge branch 'main' into GH20_geometry_tests

2f68c0a

Merge branch 'main' into GH20_geometry_tests

0427a50

jGaboardi marked this pull request as ready for review October 11, 2024 18:50

jGaboardi marked this pull request as draft October 11, 2024 18:50

jGaboardi added 2 commits October 12, 2024 14:30

update geom testing helper

2ccbace

rmeove spacing

2061306

jGaboardi marked this pull request as ready for review October 12, 2024 18:39

jGaboardi requested a review from martinfleis October 12, 2024 18:39

jGaboardi changed the title ~~first round geometry.voronoi_skeleton() tests~~ first round geometry.voronoi_skeleton() tests Oct 14, 2024

martinfleis reviewed Oct 15, 2024

View reviewed changes

doctring for max_segment_length

c6d3d75

jGaboardi mentioned this pull request Oct 15, 2024

full fua testing for simplify_network() #41

Merged

.buffer(0) not needed for certain scenarios in polygonize() conftest

8486f4b

martinfleis approved these changes Oct 15, 2024

View reviewed changes

jGaboardi merged commit abbd153 into main Oct 15, 2024
8 checks passed

jGaboardi deleted the GH20_geometry_tests branch October 15, 2024 19:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

first round `geometry.voronoi_skeleton()` tests #27

first round `geometry.voronoi_skeleton()` tests #27

jGaboardi commented Oct 6, 2024

jGaboardi Oct 6, 2024

martinfleis Oct 15, 2024

jGaboardi commented Oct 6, 2024 •

edited

Loading

martinfleis commented Oct 6, 2024

jGaboardi Oct 6, 2024

martinfleis Oct 6, 2024

jGaboardi Oct 6, 2024

jGaboardi Oct 6, 2024

martinfleis Oct 15, 2024

jGaboardi commented Oct 7, 2024

jGaboardi commented Oct 12, 2024

martinfleis Oct 15, 2024

martinfleis Oct 15, 2024

martinfleis Oct 15, 2024

jGaboardi Oct 15, 2024

jGaboardi Oct 15, 2024

jGaboardi Oct 15, 2024

martinfleis left a comment

first round geometry.voronoi_skeleton() tests #27

first round geometry.voronoi_skeleton() tests #27

Conversation

jGaboardi commented Oct 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jGaboardi commented Oct 6, 2024 • edited Loading

martinfleis commented Oct 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jGaboardi commented Oct 7, 2024

jGaboardi commented Oct 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

martinfleis left a comment

Choose a reason for hiding this comment

first round `geometry.voronoi_skeleton()` tests #27

first round `geometry.voronoi_skeleton()` tests #27

jGaboardi commented Oct 6, 2024 •

edited

Loading