doc work + type hints + refactor simplify.simplify_{singletons, pairs}(), etc.
#116
Conversation
jGaboardi
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
=====================================
Coverage 98.9% 99.0%
=====================================
Files 6 6
Lines 936 954 +18
=====================================
+ Hits 926 944 +18
Misses 10 10
|
| _id_np = lambda x: sum(artifacts.loc[artifacts["comp"] == x.comp]["non_planar"]) # noqa: E731 | ||
| artifacts["non_planar_cluster"] = artifacts.apply(_id_np, axis=1) |
There was a problem hiding this comment.
Sometimes I wonder if refactors of this sort are worth it. I don't consider the original less readable (maybe more), and it does not require linting exception.
There was a problem hiding this comment.
While I think this is more readable, I completely understand your view. I have no problem reverting.
| _1st = pd.DataFrame() | ||
| _2nd = pd.DataFrame() |
There was a problem hiding this comment.
More readable for me, but I have no problem reverting.
Agreed. Was thinking that when I was pushing this up. |
|
So how do we feel if I revert most of the non-function refactors? I probably went too far down the rabbit hole of this. |
|
Leave it as it is but avoid doing that next time :) |
|
Fair enough. |
|
@martinfleis Is this OK to merge? |
|
Yeah |
This PR:
simplify.simplify_pairs()simplify.simplify_singletons()non-planar clusters of value 2simplify@L351simplify@L355