Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document & refactor artifacts.get_artifacts() #103

Merged
merged 3 commits into from
Nov 24, 2024

Conversation

jGaboardi
Copy link
Collaborator

@jGaboardi jGaboardi commented Nov 22, 2024

This PR:

sgeop/artifacts.py Show resolved Hide resolved
@martinfleis
Copy link
Contributor

Ah, too early to approve. Some failures caught by CI.

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.7%. Comparing base (b2a1e53) to head (7bd0f0d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #103     +/-   ##
=======================================
+ Coverage   98.6%   98.7%   +0.1%     
=======================================
  Files          6       6             
  Lines        921     936     +15     
=======================================
+ Hits         908     924     +16     
+ Misses        13      12      -1     
Files with missing lines Coverage Δ
sgeop/artifacts.py 97.3% <100.0%> (+0.4%) ⬆️
---- 🚨 Try these New Features:

@jGaboardi jGaboardi merged commit ba343d0 into main Nov 24, 2024
11 checks passed
@jGaboardi jGaboardi deleted the GH20_artifacts_get_artifacts branch November 24, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants