Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(toe): update graphql-toe and add instructions to README #3765

Merged
merged 3 commits into from
Mar 21, 2025

Conversation

benjie
Copy link
Contributor

@benjie benjie commented Mar 21, 2025

Summary

Hi, I'm the maintainer of graphql-toe and we just put out a new release, v1.0.0-rc.0, which fixes an issue where errored arrays would be replaced with a null prototype object with array indicies but not an instance of array. We've also overhauled the README with greater detail.

Set of changes

This PR:

  • upgrades to this new release of graphql-toe
  • moves wonka from dependencies to devDependencies
  • adds extra detail to the README

Please check the instructions I placed in the README, I'm not familiar with the exchanges system (I don't really do frontend work these days, mostly just backend stuff!) so am not certain I put the exchange in the correct position in the array. The tests didn't help clue me in since they don't seem to follow this pattern.

cc @JoviDeCroock who I have been DM-ing about this :)

Copy link

changeset-bot bot commented Mar 21, 2025

⚠️ No Changeset found

Latest commit: 7857e55

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs a changeset

@benjie
Copy link
Contributor Author

benjie commented Mar 21, 2025

Though this is a major release of graphql-toe, it's only a patch release for this exchange - it fixes a bug and adds some documentation. Changeset added and other issues addressed 👍

@benjie benjie changed the title Update @urql/exchange-throw-on-error chore(throw-on-error): update graphql-toe Mar 21, 2025
@benjie benjie changed the title chore(throw-on-error): update graphql-toe chore(toe): update graphql-toe Mar 21, 2025
@benjie benjie changed the title chore(toe): update graphql-toe chore(toe): update graphql-toe and add instructions to README Mar 21, 2025
@JoviDeCroock JoviDeCroock merged commit 21fc766 into urql-graphql:main Mar 21, 2025
25 checks passed
@github-actions github-actions bot mentioned this pull request Mar 21, 2025
JoviDeCroock added a commit that referenced this pull request Mar 21, 2025
@benjie benjie deleted the upgrade-toe branch March 21, 2025 13:29
JoviDeCroock added a commit that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants