fix incorrect total number in page when paginating beanie query with fetch_links=True #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry being modified
IterableTrucks
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1199 +/- ##
==========================================
- Coverage 93.26% 92.69% -0.58%
==========================================
Files 35 38 +3
Lines 1040 1314 +274
==========================================
+ Hits 970 1218 +248
- Misses 70 96 +26 ☔ View full report in Codecov by Sentry. |
|
@IterableTrucks Could you please fix lint errors? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beanie's find_many method will modify the limit and offset number of the query. When querying with fetch_links=False as default, this will not be a problem, but when fetch_links=True the implicitly created aggregation pipeline will add limit and skip stages which is incorrect to count the total number. To fix this problem, count query should be placed before items query and the fetch_links should respect the parameter's value in paginate method.